It's not a temp fix. It's a long term repair as an alternative to line replacment. I have both tranny lines done that way--done in 1979, and my gas line and brake lines were done in 1987. They have never had any issues, and they won't have any issues because the repair will outlive the lines. I feel just as confidant, if not more confidant with the repairs, than I would with new lines.
I don't do things the wrong way and wouldn't do/suggest such a repair unless it met the higest level of mechanical soundness. It's the correct way to repair a high pressure steel line rather than replacing it. It will meet any automotive safety inspection mandates governing repaired high pressure lines, and it's an approved repair by any technical mechanical repair publication that comes from a credible source. The only downside is that anal resto/number match folks scream bloody murder, and they would rather hang a chinese part on the car to make the judges happy, even if the part is a substandard pos. Of course the line must be sound, and I'd bet money that the pinhole is from chaffing, not corrosion.